[nest] Use AST-based CommonJS import rewriting#2001
Open
boomyao wants to merge 1 commit into
Open
Conversation
Signed-off-by: yao <zhangyaoruo@outlook.com>
🦋 Changeset detectedLatest commit: ac21487 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
@boomyao is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| } | ||
|
|
||
| function getLeadingSyntaxByteOffset(source: string): number { | ||
| let index = source.startsWith('#!') ? skipLineComment(source, 0) : 0; |
Contributor
There was a problem hiding this comment.
Suggested change
| let index = source.startsWith('#!') ? skipLineComment(source, 0) : 0; | |
| let index = 0; |
SWC byte position mapper computes incorrect offset for files with shebang lines, causing Unable to map SWC byte position X to a string index errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing